Pattern Pages: Show link to "Read This First" just after the H1 on each pattern page #3320
+184
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
added
the
Infrastructure
howard-e
changed the title
read-this-first.html appears from APGread-this-first.html appears on from APG
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Topic: Issue 3293: Adding "Read This First" link to the top of each pattern page<jugglinmike> github: https://github.com//pull/3320 <jugglinmike> Matt_King: Everything looks good, here. We have all the necessary reviews, so thanks to everyone for that <jugglinmike> Matt_King: This work is tricky to merge, though, because it requires coordination between two repositories <jugglinmike> howard-e: This patch can land before the corresponding pull request to the "build" repository. Still, I would advise not to merge this until that review is complete <jugglinmike> Matt_King: When the review is complete there, can you comment on this issue and say that it's safe to merge? <jugglinmike> howard-e: Sure <jugglinmike> Matt_King: Great. I think this is really good. I think it's a very positive change. |
|
@howard-e are we ready for this to land yet? |
mcking65
changed the title
read-this-first.html appears on from APG
|
@mcking65 the related build repo PR#422 has been approved so this PR is ready to be merged. |
mcking65
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3293
Additionally, this PR ensures the pages that
/content/shared/templates/read-this-first.htmlappears on is controlled from this repository with the new/shared/js/read-this-first.jsscript. That was being done fromw3c/wai-aria-practicesby manually adding the template into the patterns and practices index pages. This was discussed in Jul 22, 2025 TF meeting.The script is doing the same by inserting the template content after the first
h1found on the page.This PR means the insertion from
w3c/wai-aria-practicesshould be removed. Note that this should be reviewed and merged before w3c/wai-aria-practices#422 is merged.WAI Preview Link (Last built on Tue, 19 Aug 2025 16:56:44 GMT).